bryanck commented on code in PR #4897:
URL: https://github.com/apache/iceberg/pull/4897#discussion_r884379240


##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -279,9 +279,10 @@ private static boolean isCreate(UpdateTableRequest 
request) {
   }
 
   private static TableMetadata create(TableOperations ops, TableMetadata 
start, UpdateTableRequest request) {
-    TableMetadata.Builder builder = TableMetadata.buildFrom(start);
-
     // the only valid requirement is that the table will be created
+    request.requirements().forEach(requirement -> 
requirement.validate(ops.current()));

Review Comment:
   I added this so the assertion for validation check exception message is 
consistent with other validation checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to