rdblue commented on code in PR #4897:
URL: https://github.com/apache/iceberg/pull/4897#discussion_r884905436
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -163,7 +162,7 @@ public void testCreateNamespace() {
Assert.assertFalse("Namespace should not exist",
catalog.namespaceExists(NS));
catalog.createNamespace(NS);
- Assert.assertEquals("Catalog should have the created namespace",
ImmutableList.of(NS), catalog.listNamespaces());
+ Assert.assertTrue("Catalog should have the created namespace",
catalog.listNamespaces().contains(NS));
Review Comment:
Yeah, good call here. It's fine if the catalog creates default namespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
