huaxingao commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r884403789
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -167,6 +167,16 @@ private TableProperties() {
"write.delete.parquet.row-group-check-max-record-count";
public static final int PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT_DEFAULT =
10000;
+ public static final String DEFAULT_PARQUET_BLOOM_FILTER_ENABLED =
"write.parquet.bloom-filter-enabled.default";
Review Comment:
Sounds good. I have removed `DEFAULT_PARQUET_BLOOM_FILTER_ENABLED`. Now user
needs to enable bloom filter for individual column using
`PARQUET_BLOOM_FILTER_COLUMN_ENABLED_PREFIX`. If the column is a complex type,
user needs to enable the column inside the complex type, for example,
`set(PARQUET_BLOOM_FILTER_COLUMN_ENABLED_PREFIX + "struct_col.int_field",
"true")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
