huaxingao commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r884405624


##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -112,7 +109,17 @@ public static Object[][] parameters() {
             ),
             "avro",
             false,
-            WRITE_DISTRIBUTION_MODE_RANGE
+            WRITE_DISTRIBUTION_MODE_RANGE,
+            false
+        },
+        { "testhadoop", SparkCatalog.class.getName(),
+            ImmutableMap.of(
+                "type", "hadoop"
+            ),
+            "parquet",
+            RANDOM.nextBoolean(),
+            WRITE_DISTRIBUTION_MODE_HASH,
+            true

Review Comment:
   I want to have some bloom filter write/read tests that involve copy on write 
or merge on read. I think this is the only place that test copy on write or 
merge on read (I maybe wrong). That's why I added a parameter here to turn on 
bloom filter to test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to