rdblue commented on code in PR #4898:
URL: https://github.com/apache/iceberg/pull/4898#discussion_r884938128
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -64,14 +64,15 @@ public interface ManifestFile {
"Summary for each partition");
Types.NestedField KEY_METADATA = optional(519, "key_metadata",
Types.BinaryType.get(),
"Encryption key metadata blob");
- // next ID to assign: 520
+ Types.NestedField SCHEMA_ID = optional(520, "schema_id",
Types.IntegerType.get(), "Schema ID");
Review Comment:
What is the value of adding the schema ID to a manifest file? Manifests can
contain files with different schemas and I don't think there is a way to filter
manifests based on the schema of the data files it may contain. At best, you
could fill this in if all of the files in the manifest had the same schema ID,
but that's really unlikely. I'm not sure it would be worth the code and the
metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
