ConeyLiu commented on code in PR #4898:
URL: https://github.com/apache/iceberg/pull/4898#discussion_r885276415


##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -47,7 +47,9 @@ private V2Metadata() {
       ManifestFile.ADDED_ROWS_COUNT.asRequired(),
       ManifestFile.EXISTING_ROWS_COUNT.asRequired(),
       ManifestFile.DELETED_ROWS_COUNT.asRequired(),
-      ManifestFile.PARTITION_SUMMARIES
+      ManifestFile.PARTITION_SUMMARIES,
+      ManifestFile.KEY_METADATA,

Review Comment:
   I am not sure this is right, please correct me. Because I need to keep the 
schema matching the `IndexedManifestFile.get` method. 
   
   ```java
           case 13:
             return wrapped.partitions();
           case 14:
             return wrapped.keyMetadata();
           case 15:
             return wrapped.schemaId();
           default:
             throw new UnsupportedOperationException("Unknown field ordinal: " 
+ pos);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to