rdblue commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r884954935
##########
api/src/main/java/org/apache/iceberg/expressions/Binder.java:
##########
@@ -91,12 +91,21 @@ static Expression bind(StructType struct,
}
public static Set<Integer> boundReferences(StructType struct,
List<Expression> exprs, boolean caseSensitive) {
+ return boundReferences(struct, exprs, caseSensitive, false);
+ }
+
+ public static Set<Integer> boundReferences(
+ StructType struct, List<Expression> exprs, boolean caseSensitive,
boolean alreadyBound) {
Review Comment:
I don't think it is a good idea to add a second boolean argument to this
method. It is confusing enough with just one.
How about using a different method name for this and then renaming this to a
be a private internal implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
