rdblue commented on code in PR #4831:
URL: https://github.com/apache/iceberg/pull/4831#discussion_r884959229
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -291,12 +304,32 @@ public <D> FileAppender<D> build() throws IOException {
.withWriteMode(writeMode)
.withRowGroupSize(rowGroupSize)
.withPageSize(pageSize)
- .withDictionaryPageSize(dictionaryPageSize)
- .build(),
+ .withDictionaryPageSize(dictionaryPageSize);
+
+ for (Map.Entry<String, String> entry :
columnBloomFilterEnabled.entrySet()) {
+ String colPath = entry.getKey();
+ String bloomEnabled = entry.getValue();
+ parquetWriteBuilder.withBloomFilterEnabled(colPath,
Boolean.valueOf(bloomEnabled));
+ }
+
+ return new ParquetWriteAdapter<>(
+ parquetWriteBuilder.build(),
metricsConfig);
}
}
+ private static Map<String, String> bloomColumnConfigMap(String prefix,
Map<String, String> config) {
+ Map<String, String> columnBloomFilterConfig = Maps.newHashMap();
+ config.keySet().stream()
+ .filter(key -> key.startsWith(prefix))
+ .forEach(key -> {
+ String columnPath = key.replaceFirst(prefix, "");
Review Comment:
Since this uses column name in the config, is there any logic to update
these configs when columns are renamed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
