rdblue commented on code in PR #4906:
URL: https://github.com/apache/iceberg/pull/4906#discussion_r885031999
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -1129,7 +1141,9 @@ public void testCompleteCreateTransaction() {
Assert.assertEquals("Table properties should be a superset of the
requested properties",
properties.entrySet(),
Sets.intersection(properties.entrySet(),
table.properties().entrySet()));
- Assert.assertEquals("Table location should match requested",
"file:/tmp/ns/table", table.location());
+ if (!supportsServerManagedLocation()) {
Review Comment:
Should this be `supportsClientLocations`? I think it's reasonable to say
that the server doesn't support client requested locations, rather than
"supports" managing locations (which is to say it overrides them).
Or may be this should be `overridesRequestedLocation()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
