kbendick commented on code in PR #4906:
URL: https://github.com/apache/iceberg/pull/4906#discussion_r885039255
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -155,6 +155,14 @@ protected boolean supportsServerSideRetry() {
return false;
}
+ protected boolean supportsServerManagedLocation() {
+ return false;
+ }
+
+ protected boolean supportsNamesWithSlashes() {
Review Comment:
Is that for escaped slashes in the typical way or for the REST catalogs
escaped slashes that use `%00` (Null byte)?
I’m good with not requiring that server implementations require this (I’m
almost certain it’s already not required). But would want to ensure the spec is
up to date on that re: having to support it or not. But if the null-byte can
open up security problems (which in general it can) then I can understand
people deciding tables / namespaces really don’t benefit from having slashes in
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
