ConeyLiu commented on code in PR #4898:
URL: https://github.com/apache/iceberg/pull/4898#discussion_r885485188
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -39,6 +39,13 @@
*/
int specId();
+ /**
+ * Return id of the schema when write this file.
+ */
+ default int schemaId() {
+ return -1;
Review Comment:
I tried with throw an exception and then we need to add more `try catch` to
wrap the function call. I keep this with -1 and add comments for the -1 means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
