samredai commented on code in PR #4792:
URL: https://github.com/apache/iceberg/pull/4792#discussion_r885911526
##########
python/src/iceberg/io/base.py:
##########
@@ -41,10 +41,10 @@ class InputStream(Protocol): # pragma: no cover
implementation's `open(...)` method. These methods are a subset of
IOBase/RawIOBase.
"""
- def read(self, size: int) -> bytes:
+ def read(self, n: int = -1) -> bytes:
Review Comment:
I used that to be consistent with the python IO built-ins. The value is
described here: https://docs.python.org/3/library/io.html#io.RawIOBase.read
> Read up to size bytes from the object and return them. As a convenience,
if size is unspecified or -1, all bytes until EOF are returned. Otherwise, only
one system call is ever made. Fewer than size bytes may be returned if the
operating system call returns fewer than size bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
