RussellSpitzer commented on code in PR #4919: URL: https://github.com/apache/iceberg/pull/4919#discussion_r886068419
########## dev/source-release.sh: ########## @@ -112,7 +112,7 @@ tarball=$tag.tar.gz git archive $release_hash --worktree-attributes --prefix $tag/ -o $projectdir/$tarball echo "Signing the tarball..." -[[ -z "$keyid" ]] && keyopt="-u $keyid" +[[ -n "$keyid" ]] && keyopt="-u $keyid" Review Comment: Yeah it took me a couple takes to realize the mistake here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
