kbendick commented on code in PR #4919: URL: https://github.com/apache/iceberg/pull/4919#discussion_r886203054
########## dev/source-release.sh: ########## @@ -112,7 +112,7 @@ tarball=$tag.tar.gz git archive $release_hash --worktree-attributes --prefix $tag/ -o $projectdir/$tarball echo "Signing the tarball..." -[[ -z "$keyid" ]] && keyopt="-u $keyid" +[[ -n "$keyid" ]] && keyopt="-u $keyid" Review Comment: What I've done in the past is add a function that logs either way, so logs X on true and Y on false, so we'd get `No keyid is found in variable \\$keyid, skipping adding signature to tarball` in the untrue path (just some indicator it was taken). ########## dev/source-release.sh: ########## @@ -112,7 +112,7 @@ tarball=$tag.tar.gz git archive $release_hash --worktree-attributes --prefix $tag/ -o $projectdir/$tarball echo "Signing the tarball..." -[[ -z "$keyid" ]] && keyopt="-u $keyid" +[[ -n "$keyid" ]] && keyopt="-u $keyid" Review Comment: What I've done in the past is add a function that logs either way, so logs X on true and Y on false, so we'd get `No keyid is found in variable \\$keyid, skipping adding signature to tarball` in the untrue path (just some indicator that the failed path was taken). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
