dramaticlly opened a new pull request, #4923: URL: https://github.com/apache/iceberg/pull/4923
Inspired by #4811 , instead of using introduce a new `Makefile` for defining arbitrary development task execution, we can actually leverage the `taskipy` and put task execution logic inside the `pyproject.toml`. - It adds a new development dependency on `taskipy`, it defines custom logic in single source of truth `pyproject.toml` and it can also integrate with poetry nicely in upcoming #4844 - It can potentially replace the Makefile (also version pinned in setup.cfg), instead of calling `make lint`, we can use `task lint`. With poetry it will become `poetry run task lint`. - Task discovery is easier with ```bash $ task -l install pip install -e ".[dev,arrow]" lint pre-commit run --all-files test coverage run --source=src/ -m pytest tests/ && coverage report -m --fail-under=90 && coverage html && coverage xml ``` --- Example Usage is similar to what we have today, once installed, we can just call `task install` `task lint` `task test` Disclaim: It might be a bit dumb today, as to do `task install` we need to install the taskipy first. But I think it will get better once we adopt poetry CC @Fokko @samredai @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
