Fokko commented on code in PR #4923: URL: https://github.com/apache/iceberg/pull/4923#discussion_r886919638
########## python/pyproject.toml: ########## @@ -47,3 +47,13 @@ ignore_missing_imports = true [tool.coverage.run] source = ['src/'] + +[tool.taskipy.tasks] +install = "pip install -e \".[dev,arrow]\"" +lint = "pre-commit run --all-files" +test = """ + coverage run --source=src/ -m pytest tests/ && Review Comment: I would suggest getting rid of the indentation here, this will give us a nicer listing: Before: ``` $ task -l install pip install -e ".[dev,arrow]" lint pre-commit run --all-files test coverage run --source=src/ -m pytest tests/ && coverage report -m --fail-under=90 && coverage html && coverage xml ``` after: ``` ➜ python git:(taskipy) ✗ task -l install pip install -e ".[dev,arrow]" lint pre-commit run --all-files test coverage run --source=src/ -m pytest tests/ && coverage report -m --fail-under=90 && coverage html && coverage xml ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
