samredai commented on code in PR #4929:
URL: https://github.com/apache/iceberg/pull/4929#discussion_r886809691
##########
python/src/iceberg/conversions.py:
##########
@@ -53,6 +53,13 @@
from iceberg.utils.decimal import decimal_to_bytes, unscaled_to_decimal
+_bool_struct = Struct("<?")
Review Comment:
Do these count as constants? If so the python style guide recommends all
caps for the name.
*PEP8 - Constants*
> Constants are usually defined on a module level and written in all capital
letters with underscores separating words. Examples include MAX_OVERFLOW and
TOTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
