Fokko commented on code in PR #4929:
URL: https://github.com/apache/iceberg/pull/4929#discussion_r886814317
##########
python/src/iceberg/conversions.py:
##########
@@ -53,6 +53,13 @@
from iceberg.utils.decimal import decimal_to_bytes, unscaled_to_decimal
+_bool_struct = Struct("<?")
Review Comment:
Since they are private (starting with an underscore), they shouldn't be used
outside of the file. We could also consolidate this later on with my open PR:
https://github.com/apache/iceberg/pull/4920/files#diff-9747a5712c71edff07e52c56ae999d30fa9dde758ba94e376acd16819e055731R23-R27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
