flyrain commented on PR #4588: URL: https://github.com/apache/iceberg/pull/4588#issuecomment-1145147058
Sorry, I haven't got chance to review. The changes of class `Deletes` and `DeleteFilter` are introduced by my PR #4683, which can read deleted rows by using metadata column `_deleted`. It may affect how we collect the deletes metrics. Would recommend to take a look at #4683, @wypoon. I will also review this PR a bit later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
