RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r888142184
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -152,9 +220,53 @@ public StructLikeSet rowSet(String name, Table table,
String... columns) {
set.add(rowWrapper.wrap(row));
});
+ extractDeleteCount();
return set;
}
+ private void extractDeleteCount() {
+ // Get the executionId of the query we just executed
+ List<Long> executed = listener.executed();
+ long lastExecuted = executed.get(executed.size() - 1);
+ // Ensure that the execution end was registered
Review Comment:
Also can you please add this to the Num Splits PR so we can have a few tests
in there as well? This will be really useful for all of our future metric
additions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
