rdblue commented on code in PR #4938:
URL: https://github.com/apache/iceberg/pull/4938#discussion_r889023604
##########
api/src/main/java/org/apache/iceberg/expressions/Binder.java:
##########
@@ -91,12 +91,21 @@ static Expression bind(StructType struct,
}
public static Set<Integer> boundReferences(StructType struct,
List<Expression> exprs, boolean caseSensitive) {
+ return references(struct, exprs, caseSensitive, false);
+ }
+
+ public static Set<Integer> references(
+ StructType struct, List<Expression> exprs, boolean caseSensitive,
boolean alreadyBound) {
Review Comment:
Can we detect that an expression is unbound? Maybe identify named refs and
return? Then we could just use one method for everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
