rdblue commented on code in PR #4938:
URL: https://github.com/apache/iceberg/pull/4938#discussion_r890267725
##########
api/src/main/java/org/apache/iceberg/expressions/Binder.java:
##########
@@ -91,12 +91,21 @@ static Expression bind(StructType struct,
}
public static Set<Integer> boundReferences(StructType struct,
List<Expression> exprs, boolean caseSensitive) {
+ return references(struct, exprs, caseSensitive, false);
+ }
+
+ public static Set<Integer> references(
+ StructType struct, List<Expression> exprs, boolean caseSensitive,
boolean alreadyBound) {
Review Comment:
Not all expressions are bound or unbound. What about just trying to bind the
expression and catching the exception that is thrown if it's already bound?
Then you can just move on and return the references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
