kbendick commented on PR #4953: URL: https://github.com/apache/iceberg/pull/4953#issuecomment-1146738542
Though I do appreciate the cleanup in general 👍 Just I agree most of all with Jack’s original argument. > I think we should instead suppress the warning, because: I think we should instead suppress the warning, because: 1. this might change the hashcode of the class object? We should verify 2. if more fields are added, we need to get back to use Objects.hash again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
