kbendick commented on PR #4953: URL: https://github.com/apache/iceberg/pull/4953#issuecomment-1150333821
> > I don't think that we guarantee stability of hashCode, nor should we. > > Yes that's a good point, it's hard to guarantee and also not worth the effort. In that case I think we can just move to use `hashCode`, sorry for the back and forth. Nope. No additional comments. This looks good to me. I agree we don't guarantee hashCode (nor should we), but the rule is beneficial to avoid the unnecessary array allocation. Thanks for this and sorry for the back and forth @amogh-jahagirdar! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
