karuppayya commented on code in PR #4652:
URL: https://github.com/apache/iceberg/pull/4652#discussion_r889852765
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +81,33 @@ public interface DeleteOrphanFiles extends
Action<DeleteOrphanFiles, DeleteOrpha
*/
DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
+ /**
+ * Pass a mode for handling the files that cannot be determined if they are
orphan
+ * @param mode mode for handling files that cannot be determined if they are
orphan
+ * @return this for method chaining
+ */
+ default DeleteOrphanFiles prefixMismatchMode(PrefixMisMatchMode mode) {
+ throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement prefixMismatchMode");
+ }
+
+ /**
+ * Pass a list of schemes to be considered equivalent when finding orphan
files
+ * @param equivalentSchemes list of equivalent schemes
+ * @return this for method chaining
+ */
+ default DeleteOrphanFiles equivalentSchemes(List<String> equivalentSchemes) {
Review Comment:
@aokolnychyi
Do you mean create a make a map like s3a: s3, s3n: s3, s3a: s3 (similarly
for authorities) ie map each scheme in the equiavalent list to same name in
this case `s3`
And during normalization, look up the map and populate the scheme and
authorities, so that comparisons are just `equals` instead of having to search
in a list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
