karuppayya commented on code in PR #4652:
URL: https://github.com/apache/iceberg/pull/4652#discussion_r892772634
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java:
##########
@@ -143,6 +148,24 @@ public BaseDeleteOrphanFilesSparkAction
executeDeleteWith(ExecutorService execut
return this;
}
+ @Override
+ public DeleteOrphanFiles prefixMismatchMode(PrefixMisMatchMode mismatchMode)
{
+ this.prefixMismatchMode = mismatchMode;
+ return this;
+ }
+
+ @Override
+ public DeleteOrphanFiles equivalentSchemes(List<String> schemes) {
+ this.equivalentSchemes = schemes;
Review Comment:
I have changed the implementation a bit to use Maps.
We might hit the serialization issues in case of Maps.
We are using HashMap directly in our code(which is serializable), is it ok
to leave it as is?
Also, I am now making a copy of the the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
