Fokko commented on code in PR #4920: URL: https://github.com/apache/iceberg/pull/4920#discussion_r890195280
########## python/src/iceberg/avro/decoder.py: ########## @@ -0,0 +1,197 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import datetime +import decimal +import struct + +from iceberg.io.base import InputStream + +STRUCT_FLOAT = struct.Struct("<f") # big-endian float +STRUCT_DOUBLE = struct.Struct("<d") # big-endian double +STRUCT_SIGNED_SHORT = struct.Struct(">h") # big-endian signed short +STRUCT_SIGNED_INT = struct.Struct(">i") # big-endian signed int +STRUCT_SIGNED_LONG = struct.Struct(">q") # big-endian signed long + + +class BinaryDecoder: + """Read leaf values.""" + + _input_stream: InputStream + + def __init__(self, input_stream: InputStream) -> None: + """ + reader is a Python object on which we can call read, seek, and tell. + """ + self._input_stream = input_stream + + def read(self, n: int) -> bytes: + """ + Read n bytes. + """ + if n < 0: + raise ValueError(f"Requested {n} bytes to read, expected positive integer.") + read_bytes = self._input_stream.read(n) + if len(read_bytes) != n: + raise ValueError(f"Read {len(read_bytes)} bytes, expected {n} bytes") + return read_bytes + + def read_boolean(self) -> bool: + """ + a boolean is written as a single byte + whose value is either 0 (false) or 1 (true). + """ + return ord(self.read(1)) == 1 + + def read_int(self) -> int: + """ + int and long values are written using variable-length, zigzag coding. + """ + return self.read_long() + + def read_long(self) -> int: + """ + int and long values are written using variable-length, zigzag coding. Review Comment: There is no minimal nit threshold from my side. I like the suggestion, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
