singhpk234 commented on code in PR #4956:
URL: https://github.com/apache/iceberg/pull/4956#discussion_r890346116
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -192,6 +193,10 @@ private void commitOperation(SnapshotUpdate<?> operation,
String description) {
extraSnapshotMetadata.forEach(operation::set);
}
+ if (!CallerWithCommitMetadata.commitProperties().isEmpty()) {
+ CallerWithCommitMetadata.commitProperties().forEach(operation::set);
+ }
Review Comment:
[question] Should we also add this to SparkPositionDeltaWrite
https://github.com/apache/iceberg/blob/b06a89cebd5099b40b188c4c40ea7b1a23d3427a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java#L250
since starting 3.2 iceberg support MOR with pos deletes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
