singhpk234 commented on code in PR #4956:
URL: https://github.com/apache/iceberg/pull/4956#discussion_r890342898
##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -174,6 +175,10 @@ private void commitOperation(SnapshotUpdate<?> operation,
String description) {
extraSnapshotMetadata.forEach(operation::set);
}
+ if (!CallerWithCommitMetadata.commitProperties().isEmpty()) {
+ CallerWithCommitMetadata.commitProperties().forEach(operation::set);
+ }
Review Comment:
[doubt](Probably not in scope of PR) Should we add a validation that the
keys passed from here as well as extraSnapshotMetadata doesn't override the
keys already present in the snasphot-summary ? Or this functionality is
intended to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
