flyrain commented on code in PR #4870: URL: https://github.com/apache/iceberg/pull/4870#discussion_r893833783
########## api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +/** + * A scan task for inserted data records generated by adding a data file to the table. + * <p> + * Note that added files may have matching position deletes produced in the same snapshot. Review Comment: Eq delete doesn't apply to the data files in the same snapshot, which is written in the spec, https://iceberg.apache.org/spec/#scan-planning. > An equality delete file must be applied to a data file when all of the following are true: > The data file’s sequence number is strictly less than the delete’s sequence number -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
