flyrain commented on code in PR #4870: URL: https://github.com/apache/iceberg/pull/4870#discussion_r893929732
########## api/src/main/java/org/apache/iceberg/DeletedRowsScanTask.java: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +/** + * A scan task for deleted data records generated by adding delete files to the table. + */ +public interface DeletedRowsScanTask extends ChangelogScanTask { Review Comment: If we output pos and data file names in the result, we can understand the rows being deleted multiple times, and deduplicate them while merging. In that way, we don't have to change anything in the scan task. Oh, that doesn't work for the case that we don't merge snapshots which deletes the same row multiple times. Never mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
