kbendick commented on code in PR #5009:
URL: https://github.com/apache/iceberg/pull/5009#discussion_r893934029
##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -823,16 +823,14 @@ public void testAddDeleteFilesMultipleSpecs() {
Map<String, String> summary = snapshot.summary();
- Assert.assertEquals("Should change 4 partitions", "4",
summary.get(CHANGED_PARTITION_COUNT_PROP));
+ Assert.assertEquals("Should change 3 partitions", "3",
summary.get(CHANGED_PARTITION_COUNT_PROP));
Assert.assertEquals("Should add 1 data file", "1",
summary.get(ADDED_FILES_PROP));
Assert.assertEquals("Should have 4 data files", "4",
summary.get(TOTAL_DATA_FILES_PROP));
Assert.assertEquals("Should add 3 delete files", "3",
summary.get(ADDED_DELETE_FILES_PROP));
Assert.assertEquals("Should have 3 delete files", "3",
summary.get(TOTAL_DELETE_FILES_PROP));
Assert.assertEquals("Should add 3 position deletes", "3",
summary.get(ADDED_POS_DELETES_PROP));
Assert.assertEquals("Should have 3 position deletes", "3",
summary.get(TOTAL_POS_DELETES_PROP));
- Assert.assertTrue("Partition metrics must be correct",
- summary.get(CHANGED_PARTITION_PREFIX).contains(ADDED_DELETE_FILES_PROP
+ "=1"));
Review Comment:
This partition summary field is for `"partition.": "..."` (the unpartitioned
portion of the table).
As we're not writing summaries for unpartitioned fields, this needs to be
removed.
We could in theory still add a "global partition" summary if partition
summaries are enabled, but update it from `"partition."` to
`"partition.unpartitioned"` or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
