rdblue commented on code in PR #4938:
URL: https://github.com/apache/iceberg/pull/4938#discussion_r895215105
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -291,9 +292,17 @@ public <D> FileAppender<D> build() throws IOException {
.withWriteMode(writeMode)
.withRowGroupSize(rowGroupSize)
.withPageSize(pageSize)
- .withDictionaryPageSize(dictionaryPageSize)
- .build(),
- metricsConfig);
+ .withDictionaryPageSize(dictionaryPageSize);
+ // Todo: The following code needs to be improved in the bloom filter
write path PR.
Review Comment:
I think this is okay for now to get this in with tests. Thanks, @huaxingao!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
