rdblue commented on code in PR #5011:
URL: https://github.com/apache/iceberg/pull/5011#discussion_r895227352
##########
python/src/iceberg/schema.py:
##########
@@ -134,7 +138,7 @@ def _lazy_id_to_accessor(self) -> dict[int, Accessor]:
def as_struct(self) -> StructType:
"""Returns the underlying struct"""
- return self._struct
+ return StructType(*self.fields)
Review Comment:
I think I would opt to keep an inner struct like this did before, and then
define `fields` to return `this.struct.fields`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
