rdblue commented on code in PR #5011:
URL: https://github.com/apache/iceberg/pull/5011#discussion_r895227716
##########
python/src/iceberg/types.py:
##########
@@ -59,134 +62,176 @@ class IcebergType:
'IcebergType()'
"""
- @property
- def string_type(self) -> str:
- return self.__repr__()
-
- def __str__(self) -> str:
- return self.string_type
+ @classmethod
+ def __get_validators__(cls):
+ # one or more validators may be yielded which will be called in the
+ # order to validate the input, each validator will receive as an input
+ # the value returned from the previous validator
+ yield cls.validate
+
+ @classmethod
+ def validate(cls, v):
+ # When Pydantic is unable to determine the subtype
+ # In this case we'll help pydantic a bit by parsing the
+ # primitive type ourselves, or pointing it at the correct
+ # complex type by looking at the type field
+
+ if isinstance(v, str):
+ if v.startswith("decimal"):
+ m = re.search(r"decimal\((\d+),\s*(\d+)\)", v)
+ precision = int(m.group(1))
+ scale = int(m.group(2))
+ return DecimalType(precision, scale)
+ elif v.startswith("fixed"):
+ m = re.search(r"fixed\[(\d+)\]", v)
+ length = int(m.group(1))
+ return FixedType(length)
+ else:
+ return PRIMITIVE_TYPES[v]
+
+ if isinstance(v, dict):
+ if v.get("type") == "struct":
+ return StructType(**v)
+ elif v.get("type") == "list":
+ return ListType(**v)
+ elif v.get("type") == "map":
+ return MapType(**v)
+ else:
+ return NestedField(**v)
+
+ return v
@property
def is_primitive(self) -> bool:
return isinstance(self, PrimitiveType)
-@dataclass(frozen=True, eq=True)
class PrimitiveType(IcebergType):
- """Base class for all Iceberg Primitive Types
+ """Base class for all Iceberg Primitive Types"""
- Example:
- >>> str(PrimitiveType())
- 'PrimitiveType()'
- """
+ __root__: str = Field()
+
+ def __repr__(self) -> str:
+ return f"{type(self).__name__}()"
+
+ def __str__(self) -> str:
+ return self.__root__
-@dataclass(frozen=True)
class FixedType(PrimitiveType):
"""A fixed data type in Iceberg.
-
Example:
>>> FixedType(8)
FixedType(length=8)
>>> FixedType(8) == FixedType(8)
True
+ >>> FixedType(19) == FixedType(25)
+ False
"""
- length: int = field()
+ __root__: str = Field()
Review Comment:
What is `__root__`? Is there a reason not to name it `__as_str__` or
something simliar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
