RussellSpitzer commented on code in PR #4888:
URL: https://github.com/apache/iceberg/pull/4888#discussion_r898482218
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -209,7 +231,32 @@ void applyEqDelete() {
rowId++;
}
- columnarBatch.setNumRows(currentRowId);
+ newColumnarBatch.setNumRows(currentRowId);
+ return currentRowId;
+ }
+
+ /**
+ * Convert the row id mapping array to the isDeleted array.
+ *
+ * @param numRowsInRowIdMapping the num of rows in the row id mapping array
+ */
+ void rowIdMappingToIsDeleted(int numRowsInRowIdMapping) {
+ if (isDeleted == null || rowIdMapping == null) {
Review Comment:
Is this ok to return on? Seems like we should fail if isDeleted is set but
rowIdMapping is null? Or is is rowIdMapping null if there are no delete files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
