RussellSpitzer commented on code in PR #4888:
URL: https://github.com/apache/iceberg/pull/4888#discussion_r898485495
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -209,7 +231,32 @@ void applyEqDelete() {
rowId++;
}
- columnarBatch.setNumRows(currentRowId);
+ newColumnarBatch.setNumRows(currentRowId);
+ return currentRowId;
+ }
+
+ /**
+ * Convert the row id mapping array to the isDeleted array.
+ *
+ * @param numRowsInRowIdMapping the num of rows in the row id mapping array
+ */
+ void rowIdMappingToIsDeleted(int numRowsInRowIdMapping) {
+ if (isDeleted == null || rowIdMapping == null) {
Review Comment:
Oh wait I think I see, so if rowIdMapping is null it means there are no
deletes. Does that mean we treat isDeleted as always false if null? I think
that may need to be a javadoc comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
