bryanck commented on code in PR #5084:
URL: https://github.com/apache/iceberg/pull/5084#discussion_r901997846


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -556,6 +556,8 @@ private LoadTableResponse stageCreate() {
   private static List<MetadataUpdate> createChanges(TableMetadata meta) {
     ImmutableList.Builder<MetadataUpdate> changes = ImmutableList.builder();
 
+    changes.add(new MetadataUpdate.UpgradeFormatVersion(meta.formatVersion()));

Review Comment:
   I think the server-side default and the client-side default may not match? 
The issue I originally encountered was the Trino plugin had v2 as the default 
and set the initial sequence number to 1, but the server didn't receive a 
format version so treated it as v1, and failed because the sequence number was 
> 0. If the client and server are on different Iceberg versions, there could 
potentially be a mismatch in the default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to