kbendick commented on code in PR #5084:
URL: https://github.com/apache/iceberg/pull/5084#discussion_r902028547
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -556,6 +556,8 @@ private LoadTableResponse stageCreate() {
private static List<MetadataUpdate> createChanges(TableMetadata meta) {
ImmutableList.Builder<MetadataUpdate> changes = ImmutableList.builder();
+ changes.add(new MetadataUpdate.UpgradeFormatVersion(meta.formatVersion()));
Review Comment:
+1.
I could have sworn I left an almost identical comment when I reviewed this
before (the single comment I was referring to). I can possibly help with adding
a unit test for this sequence in `CatalogTests` if we’d like. Feel free to
reach out on Slack too.
I too see what you mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
