flyrain commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r905344633
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -196,14 +207,32 @@ public boolean supportColumnarReads(InputPartition
partition) {
}
private static class RowReader extends RowDataReader implements
PartitionReader<InternalRow> {
+ private long numSplits;
+
RowReader(ReadTask task) {
super(task.task, task.table(), task.expectedSchema(),
task.isCaseSensitive());
+ numSplits = task.task.files().size();
+ LOG.debug("Reading {} file split(s) for table {} using RowReader",
numSplits, task.table().name());
+ }
Review Comment:
How about moving `numSplits` to class `BaseDataReader`? This logic can be
shared by all subclass of BaseDataReader in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
