flyrain commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r904422923
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -47,4 +47,8 @@ public boolean isDeleted(long position) {
public boolean isEmpty() {
return roaring64Bitmap.isEmpty();
}
+
+ public long numberOfPositionsDeleted() {
Review Comment:
It makes sense to put it in the interface. The change of
`CustomizedPositionDeleteIndex` is minor.
Minor suggestion: `numberOfPositionsDeleted` -> `numberOfPositionDeletes`
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -47,4 +47,8 @@ public boolean isDeleted(long position) {
public boolean isEmpty() {
return roaring64Bitmap.isEmpty();
}
+
+ public long numberOfPositionsDeleted() {
Review Comment:
It makes sense to put it in the interface. The change of
`CustomizedPositionDeleteIndex` will be minor.
Minor suggestion: `numberOfPositionsDeleted` -> `numberOfPositionDeletes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
