kbendick opened a new pull request, #5135: URL: https://github.com/apache/iceberg/pull/5135
Previously, we were testing whether or not each RESTCatalog request / response had the expected fields as named in the Java class. However, we want to test that the correct names, as defined in the spec are used. This PR updates: - updates the request / response base test for `hasOnlyKnownFields` to check the serialized JSON - updates the RESTObjectMapper to allow for kebab-case - updates the CreateTableRequest tests to use `stage-create` for serialized versions, the name that is defined in the spec, vs `stageCreate`, the Java class formatted name. This PR can replace https://github.com/apache/iceberg/pull/5133 entirely (or be merged in after that one and rebasing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
