rdblue commented on code in PR #5135:
URL: https://github.com/apache/iceberg/pull/5135#discussion_r907803838
##########
core/src/test/java/org/apache/iceberg/rest/requests/TestCreateTableRequest.java:
##########
@@ -257,7 +255,7 @@ public void testBuilderDoesNotBuildInvalidRequests() {
@Override
public String[] allFieldsFromSpec() {
- return new String[] {"name", "location", "schema", "spec", "order",
"properties", "stageCreate"};
+ return new String[] {"name", "location", "schema", "spec", "order",
"stage-create", "properties"};
Review Comment:
Since we caught that this wasn't correctly testing against the spec with
`stageCreate`, I just [checked the
spec](https://github.com/apache/iceberg/blob/master/open-api/rest-catalog-open-api.yaml#L1514-L1517)
and it looks like there are more incorrect fields: `partition-spec` and
`write-order`. Can you also fix those fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
