ajantha-bhat commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r906631626
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##########
@@ -139,7 +140,10 @@ private RewriteDataFiles checkAndApplyOptions(InternalRow
args, RewriteDataFiles
private RewriteDataFiles checkAndApplyStrategy(RewriteDataFiles action,
String strategy, SortOrder sortOrder) {
// caller of this function ensures that between strategy and sortOrder, at
least one of them is not null.
- if (strategy == null || strategy.equalsIgnoreCase("sort")) {
+ if (strategy == null || strategy.equalsIgnoreCase("sort") ||
strategy.equalsIgnoreCase("zorder")) {
Review Comment:
there can be some column called `zorder` it will conflict with the
assumption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
