ajantha-bhat commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r907002522
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderStrategy.java:
##########
@@ -133,9 +133,23 @@ public SparkZOrderStrategy(Table table, SparkSession
spark, List<String> zOrderC
"Cannot perform ZOrdering, all columns provided were identity
partition columns and cannot be used.");
}
+ validateColumnsExistence(table, spark, zOrderColNames);
+
this.zOrderColNames = zOrderColNames;
}
+ private void validateColumnsExistence(Table table, SparkSession spark,
List<String> colNames) {
+ boolean caseSensitive =
Boolean.parseBoolean(spark.conf().get("spark.sql.caseSensitive"));
Review Comment:
Can you point me to an example code? I am not aware of it and couldn't find
it either.
Also, I did like this because some part of the iceberg code is doing
similarly. (by lookingup `spark.sql.caseSensitive` in the code) . Maybe I could
replace them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
