kbendick commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r907630816
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -619,12 +631,17 @@ public void alterPartition(ObjectPath tablePath,
CatalogPartitionSpec partitionS
@Override
public List<String> listFunctions(String dbName) throws CatalogException {
- return Collections.emptyList();
+ return Lists.newArrayList(partitionFunctions.keySet());
}
@Override
public CatalogFunction getFunction(ObjectPath functionPath) throws
FunctionNotExistException, CatalogException {
- throw new FunctionNotExistException(getName(), functionPath);
+ CatalogFunction catalogFunction =
partitionFunctions.get(functionPath.getObjectName());
Review Comment:
> But after we support users to add UDFs, I still want to add these two
functions, so that users do not need to manually add them again when they want
to query related partitions, I would like to provide them by default. What do
you think about this?
I agree we should register them on behalf of the users. If users will also
be able to register their own functions on the catalog, we might want to pick
slightly more specific names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
