rdblue commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r907955657
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -88,6 +88,22 @@ static <T> Literal<T> from(T value) {
"Cannot create expression literal from %s: %s",
value.getClass().getName(), value));
}
+ public static Literal<Object> fromJavaType(Object value) {
Review Comment:
I don't think this should be added to the public API. We avoided adding
support for these because Iceberg is not responsible for time zone conversions.
It would be fine to revisit that decision, but I think this is only used so
that the implementation is kept simple, although it will have poor performance.
Instead, I think this should define real functions that are typed, instead of
accepting any input type and dynamically calling functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
