aokolnychyi commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r907848096
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -204,4 +226,190 @@ public Iterable<FileScanTask> split(long splitSize) {
return ImmutableList.of(this); // don't split
}
}
+
+ static StaticDataTask.Row manifestFileToRow(PartitionSpec spec, ManifestFile
manifest, long referenceSnapshotId) {
+ return StaticDataTask.Row.of(
+ manifest.content().id(),
+ manifest.path(),
+ manifest.length(),
+ manifest.partitionSpecId(),
+ manifest.snapshotId(),
+ manifest.content() == ManifestContent.DATA ?
manifest.addedFilesCount() : 0,
Review Comment:
I think the problem is in the original schema in `ManifestsTable`, where the
counts are required. I also did not notice that data file counts are optional
in `AllManifestsTable` when I recently added counts for delete files. I think
we should continue to use 0 for compatibility but I wonder why we have such a
mismatch in nullability between these tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
