aokolnychyi commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r907852616
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -112,21 +123,26 @@ protected CloseableIterable<FileScanTask> doPlanFiles() {
Expression filter = shouldIgnoreResiduals() ? Expressions.alwaysTrue() :
filter();
ResidualEvaluator residuals = ResidualEvaluator.unpartitioned(filter);
- return
CloseableIterable.withNoopClose(Iterables.transform(table().snapshots(), snap
-> {
+ SnapshotEvaluator snapshotEvaluator = new SnapshotEvaluator(filter,
MANIFEST_FILE_SCHEMA.asStruct(),
Review Comment:
nit: if you want to keep it on one line, you could just use
`MANIFEST_FILE_SCHEMA` in the constructor of the evaluator class (you have
access to it there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
