rdblue commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r907940951
##########
python/src/iceberg/expressions/base.py:
##########
@@ -138,6 +75,24 @@ def __invert__(self) -> "BooleanExpression":
...
+class BoundPredicate(ABC):
+ def __init__(self, term, literal):
+ """A concrete predicate must have a `term` and `literal`"""
+ self._term = term
+ self._literal = literal
+
+
+class UnboundPredicate:
Review Comment:
I think this and `BoundPredicate` should extend `BooleanExpression` because
they return boolean values.
Also, there should be no need for `BoundPredicate` to extend ABC right now,
since there are no methods defined for it that aren't defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
